imay commented on a change in pull request #2089: Change refactor and
reorganize the file utils
URL: https://github.com/apache/incubator-doris/pull/2089#discussion_r343452221
##########
File path: be/src/util/file_utils.h
##########
@@ -80,7 +106,11 @@ class FileUtils {
// calc md5sum of a local file
static Status md5sum(const std::string& file, std::string* md5sum);
+ // check path(file or directory) exist with default env
static bool check_exist(const std::string& path);
+
+ // check path(file or directory) exist with env
+ static bool check_exist(const std::string& path, Env* env);
Review comment:
I think you should refactor this function to make it return error if status
is no NOT_FOUND.
And this may lead many changes, you can resolve this in another ISSUE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
