imay commented on a change in pull request #2089: Change refactor and 
reorganize the file utils 
URL: https://github.com/apache/incubator-doris/pull/2089#discussion_r344158764
 
 

 ##########
 File path: be/src/util/file_utils.cpp
 ##########
 @@ -103,19 +177,19 @@ Status FileUtils::get_children_count(Env* env, const 
std::string& dir, int64_t*
     return env->iterate_dir(dir, cb);
 }
 
-bool FileUtils::is_dir(const std::string& path) {
-    struct stat path_stat;    
-    if (stat(path.c_str(), &path_stat) != 0) {
-        return false;
+bool FileUtils::is_dir(const std::string& file_path, Env *env) {
 
 Review comment:
   ```suggestion
   bool FileUtils::is_dir(const std::string& file_path, Env* env) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to