imay commented on a change in pull request #2089: Change refactor and
reorganize the file utils
URL: https://github.com/apache/incubator-doris/pull/2089#discussion_r343457617
##########
File path: be/src/olap/task/engine_storage_migration_task.cpp
##########
@@ -262,7 +262,7 @@ OLAPStatus
EngineStorageMigrationTask::_copy_index_and_data_files(
for (auto& rs : consistent_rowsets) {
status = rs->copy_files_to(schema_hash_path);
if (status != OLAP_SUCCESS) {
- if (remove_all_dir(schema_hash_path) != OLAP_SUCCESS) {
+ if (!FileUtils::remove_all(schema_hash_path).ok()) {
Review comment:
get the status and log it if it is not OK
we prefer not do operation and check in `if` clause
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
