imay commented on a change in pull request #2089: Change refactor and
reorganize the file utils
URL: https://github.com/apache/incubator-doris/pull/2089#discussion_r343449753
##########
File path: be/src/olap/utils.cpp
##########
@@ -1013,15 +1015,15 @@ OLAPStatus move_to_trash(const
boost::filesystem::path& schema_hash_root,
// 4. check parent dir of source file, delete it when empty
string source_parent_dir = schema_hash_root.parent_path().string(); //
tablet_id level
std::set<std::string> sub_dirs, sub_files;
- if (dir_walk(source_parent_dir, &sub_dirs, &sub_files) != OLAP_SUCCESS) {
+ if (!FileUtils::list_dirs_files(source_parent_dir, &sub_dirs, &sub_files,
Env::Default()).ok()) {
Review comment:
better to get status, and print error message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
