imay commented on a change in pull request #2453: add block split bloom filter
URL: https://github.com/apache/incubator-doris/pull/2453#discussion_r357530171
##########
File path: be/src/olap/olap_cond.h
##########
@@ -109,6 +116,18 @@ class CondColumn {
bool eval(const BloomFilter& bf) const;
+ bool eval(const segment_v2::BloomFilter* bf) const;
+
+ bool can_do_bloom_filter() const {
+ for(auto cond : _conds) {
Review comment:
```suggestion
for (auto cond : _conds) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
