imay commented on a change in pull request #2453: add block split bloom filter
URL: https://github.com/apache/incubator-doris/pull/2453#discussion_r357544200
##########
File path: be/src/olap/rowset/segment_v2/column_writer.h
##########
@@ -44,13 +45,15 @@ struct ColumnWriterOptions {
double compression_min_space_saving = 0.1;
bool need_zone_map = false;
bool need_bitmap_index = false;
+ bool need_bloom_filter_index = false;
Review comment:
```suggestion
bool need_bloom_filter = false;
```
I think filter and index are in the same level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
