imay commented on a change in pull request #2453: add block split bloom filter
URL: https://github.com/apache/incubator-doris/pull/2453#discussion_r357543475
##########
File path: be/src/olap/rowset/segment_v2/segment_writer.h
##########
@@ -65,14 +67,21 @@ class SegmentWriter {
uint32_t num_rows_written() { return _row_count; }
- Status finalize(uint64_t* segment_file_size, uint64_t* bitmap_index_size);
+ Status finalize(uint64_t* segment_file_size, uint64_t* index_size);
+
+ // for ut
+ // this function should be called after finalize
+ bool is_column_has_bf_index(uint32_t col_id) {
Review comment:
```suggestion
bool has_bf_index(uint32_t col_id) const {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
