imay commented on a change in pull request #2453: add block split bloom filter
URL: https://github.com/apache/incubator-doris/pull/2453#discussion_r357541680
##########
File path: be/src/olap/utils.h
##########
@@ -512,6 +512,10 @@ bool valid_datetime(const std::string& value_str);
}\
} while (0)
+// get the highest bit of 1 in uint32_t
+// copy from java Integer.highestOneBit()
+uint32_t highest_one_bit(uint32_t i);
Review comment:
We have already had this function. Maybe `used_bits` in
"be/src/olap/serialize.h" is what you want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
