imay commented on a change in pull request #2453: add block split bloom filter
URL: https://github.com/apache/incubator-doris/pull/2453#discussion_r357543678
##########
File path: be/src/olap/rowset/segment_v2/segment_writer.h
##########
@@ -46,6 +46,8 @@ struct SegmentWriterOptions {
uint32_t num_rows_per_block = 1024;
// Todo(kks): only for UT, we should remove it when we support
bitmap_index in FE
bool need_bitmap_index = false;
+ // whether is the segment is in base rowset
+ bool is_base = false;
Review comment:
is `is_base` a good name for this option?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
