morningman commented on a change in pull request #8663:
URL: https://github.com/apache/incubator-doris/pull/8663#discussion_r838097222
##########
File path: be/src/env/env.h
##########
@@ -204,74 +199,84 @@ struct FilePathDesc {
TStorageMedium::type storage_medium = TStorageMedium::HDD;
std::string filepath;
std::string remote_path;
+ std::string storage_name;
std::string debug_string() const {
std::stringstream ss;
- ss << "local_path: " << filepath;
+ ss << "storage_medium: " << to_string(storage_medium) << ",
local_path: " << filepath;
if (!remote_path.empty()) {
- ss << ", remote_path: " << remote_path;
+ ss << ", storage_name: " << storage_name << ", remote_path: " <<
remote_path;
}
return ss.str();
}
+ static bool is_remote(TStorageMedium::type checked_storage_medium) {
+ return checked_storage_medium == TStorageMedium::S3 ||
checked_storage_medium == TStorageMedium::REMOTE_CACHE;
Review comment:
What is the difference between S3 and REMOTE_CACHE?
Why `REMOTE_CACHE` be considered as `remote`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
