pengxiangyu commented on a change in pull request #8663:
URL: https://github.com/apache/incubator-doris/pull/8663#discussion_r838148073
##########
File path: be/src/olap/data_dir.h
##########
@@ -133,9 +132,13 @@ class DataDir {
void disks_compaction_num_increment(int64_t delta);
- Env* env() {
- return _env;
- }
+ // 将segment_path_desc移到回收站，回收站位于storage_root/trash,
segment_path_desc可以是文件或目录
+ // 移动的同时将segment_path_desc的路径进行修改
+ // filepath改为：
+ //
storage_root/trash/20150619154308/delete_counter/tablet_path/segment_path,
+ // remote_path改为：
+ //
storage_root/trash/20150619154308/delete_counter/tablet_path/segment_path/tablet_uid
+ OLAPStatus move_to_trash(const FilePathDesc& segment_path_desc);
Review comment:
this is moved from src/olap/utils.h, the old move_to_trash() can only
support local files,
and it is more suitable in DataDir because one trash path is in one DataDir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
