pengxiangyu commented on a change in pull request #8663:
URL: https://github.com/apache/incubator-doris/pull/8663#discussion_r838156526
##########
File path: be/src/olap/fs/fs_util.cpp
##########
@@ -58,6 +60,42 @@ StorageMediumPB get_storage_medium_pb(TStorageMedium::type
t_storage_medium) {
}
}
+TStorageMedium::type get_t_storage_medium(StorageMediumPB storage_medium) {
+ switch (storage_medium) {
+ case StorageMediumPB::S3:
+ return TStorageMedium::S3;
+ case StorageMediumPB::SSD:
+ return TStorageMedium::SSD;
+ case StorageMediumPB::HDD:
Review comment:
I don't want to throw an exception for this function, Sometimes we have
to return a value but not an error. if storage_medium is not valid, set it to
HDD as default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
