pengxiangyu commented on a change in pull request #8663:
URL: https://github.com/apache/incubator-doris/pull/8663#discussion_r838161852
##########
File path: be/src/olap/snapshot_manager.cpp
##########
@@ -98,13 +98,13 @@ OLAPStatus SnapshotManager::release_snapshot(const string&
snapshot_path) {
continue;
}
std::string abs_path;
- RETURN_WITH_WARN_IF_ERROR(store->env()->canonicalize(store->path(),
&abs_path),
+ RETURN_WITH_WARN_IF_ERROR(Env::Default()->canonicalize(store->path(),
&abs_path),
Review comment:
DataDir has no env now. As remote storage is using StorageBackend, only
PosixEnv left，DataDir->env() is useless.
And if data_dir is a remote_cache path, it maybe multi StorageBackend type,
it can not be set as an env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
