yujun777 commented on code in PR #65657:
URL: https://github.com/apache/doris/pull/65657#discussion_r3628091232
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOlapTableStreamScan.java:
##########
@@ -276,11 +276,11 @@ public LogicalOlapTableStreamScan
withSelectedPartitionIds(List<Long> selectedPa
*/
@Override
public LogicalOlapTableStreamScan withSelectedPartitionIds(List<Long>
selectedPartitionIds,
- boolean
isPartitionPruned) {
+ boolean
hasPartitionPredicate) {
return AbstractPlan.copyWithSameId(this, () ->
new LogicalOlapTableStreamScan(relationId, (Table) table,
qualifier,
groupExpression, Optional.of(getLogicalProperties()),
- selectedPartitionIds, isPartitionPruned,
hasPartitionPredicate, selectedTabletIds,
+ selectedPartitionIds, true, hasPartitionPredicate,
selectedTabletIds,
Review Comment:
Thanks for the detailed analysis. However, this issue is outside the scope
of this PR. NormalizeOlapTableStreamScan is expected to lower a stream scan
into executable LogicalOlapScan children, and that lowering behavior already
existed before this change. This PR only fixes the partition-pruned state
propagation in LogicalOlapTableStreamScan.withSelectedPartitionIds(); it does
not change the normalization or block-rule semantics. If stream scans should
have different require_partition_filter behavior after normalization, please
open a separate issue/PR with an end-to-end reproduction, rather than blocking
this state-propagation fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
