yujun777 commented on PR #65657: URL: https://github.com/apache/doris/pull/65657#issuecomment-5042931602
Reply to the Request changes review (review 4719268246): I agree that the local builder-contract change fixes the repeated PruneOlapScanPartition rewrite. However, the remaining NormalizeOlapTableStreamScan behavior described in the review is pre-existing and unchanged by this PR. Lowering a stream into executable LogicalOlapScan base/binlog children with internally selected partition IDs is expected behavior. Treating those internal selected partitions differently for require_partition_filter is a separate semantic change, not a regression introduced by this patch. The requested changes to PruneEmptyPartition, normalized-child construction, and end-to-end SqlBlockRuleMgr coverage would expand the scope beyond this PRs partition-pruned state propagation fix. Please track that behavior in a separate issue/PR with an end-to-end reproduction instead of blocking this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
