yujun777 commented on code in PR #65657:
URL: https://github.com/apache/doris/pull/65657#discussion_r3628173059
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOlapTableStreamScan.java:
##########
@@ -276,11 +276,11 @@ public LogicalOlapTableStreamScan
withSelectedPartitionIds(List<Long> selectedPa
*/
@Override
public LogicalOlapTableStreamScan withSelectedPartitionIds(List<Long>
selectedPartitionIds,
- boolean
isPartitionPruned) {
+ boolean
hasPartitionPredicate) {
return AbstractPlan.copyWithSameId(this, () ->
new LogicalOlapTableStreamScan(relationId, (Table) table,
qualifier,
groupExpression, Optional.of(getLogicalProperties()),
- selectedPartitionIds, isPartitionPruned,
hasPartitionPredicate, selectedTabletIds,
+ selectedPartitionIds, true, hasPartitionPredicate,
selectedTabletIds,
Review Comment:
Regarding the blocking conclusion in this review:
NormalizeOlapTableStreamScan creating executable LogicalOlapScan children is
existing and expected behavior, and it is unchanged by this PR. The scope of
this PR is limited to fixing the boolean contract in
LogicalOlapTableStreamScan.withSelectedPartitionIds() and marking the stream
scan as partition-pruned. The proposed normalization/block-rule semantic change
is therefore unrelated to this patch and should be tracked separately with an
end-to-end reproduction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
