yujun777 commented on code in PR #65657:
URL: https://github.com/apache/doris/pull/65657#discussion_r3628180619
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOlapTableStreamScan.java:
##########
@@ -276,11 +276,11 @@ public LogicalOlapTableStreamScan
withSelectedPartitionIds(List<Long> selectedPa
*/
@Override
public LogicalOlapTableStreamScan withSelectedPartitionIds(List<Long>
selectedPartitionIds,
- boolean
isPartitionPruned) {
+ boolean
hasPartitionPredicate) {
return AbstractPlan.copyWithSameId(this, () ->
new LogicalOlapTableStreamScan(relationId, (Table) table,
qualifier,
groupExpression, Optional.of(getLogicalProperties()),
- selectedPartitionIds, isPartitionPruned,
hasPartitionPredicate, selectedTabletIds,
+ selectedPartitionIds, true, hasPartitionPredicate,
selectedTabletIds,
Review Comment:
I do not think this should block this PR. The builder-contract change is the
scope of this patch; NormalizeOlapTableStreamScan already lowers streams into
executable LogicalOlapScan base/binlog children with internally selected
partitions, and that behavior is unchanged here. Treating those internal
selected partitions differently for require_partition_filter is a separate
semantic decision. The requested changes to PruneEmptyPartition,
normalized-child construction, and end-to-end SqlBlockRuleMgr coverage would
expand this PR beyond the partition-pruned state propagation fix. Please track
that behavior in a separate issue/PR with an end-to-end reproduction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
