gianm commented on a change in pull request #6129: Add support for
'maxTotalRows' to incremental publishing kafka indexing task and appenderator
based realtime task
URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r210987247
##########
File path:
server/src/main/java/io/druid/segment/realtime/appenderator/AppenderatorConfig.java
##########
@@ -30,12 +30,48 @@
{
boolean isReportParseExceptions();
+ /**
+ * Maximum number of rows in memory before persisting to local storage
+ *
+ * @return
Review comment:
Please get rid of the return if it's not going to have anything useful on
it; here, and a few other places in the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
