gianm commented on a change in pull request #6129: Add support for
'maxTotalRows' to incremental publishing kafka indexing task and appenderator
based realtime task
URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r210986882
##########
File path:
extensions-core/kafka-indexing-service/src/main/java/io/druid/indexing/kafka/IncrementalPublishingKafkaIndexTaskRunner.java
##########
@@ -429,9 +429,6 @@ public void run()
// if stop is requested or task's end offset is set by call to
setEndOffsets method with finish set to true
if (stopRequested.get() || sequences.get(sequences.size() -
1).isCheckpointed()) {
Review comment:
What's the rationale behind `break`ing here if the last sequence is
checkpointed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
