gianm commented on a change in pull request #6129: Add support for
'maxTotalRows' to incremental publishing kafka indexing task and appenderator
based realtime task
URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r211040256
##########
File path:
server/src/main/java/io/druid/segment/realtime/appenderator/AppenderatorImpl.java
##########
@@ -1118,16 +1094,18 @@ public String apply(SegmentIdentifier input)
final boolean removeOnDiskData
)
{
+ if (sink.isWritable()) {
Review comment:
Hmm, to prevent races (abandonSegment _could_ be called in a separate
thread) how about having `sink.finishWriting()` return true or false,
corresponding to its writability state before the method was called? Then, only
decrement the counters if it returns true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
