gianm commented on a change in pull request #6129: Add support for
'maxTotalRows' to incremental publishing kafka indexing task and appenderator
based realtime task
URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r211040341
##########
File path:
server/src/main/java/io/druid/segment/realtime/appenderator/AppenderatorImpl.java
##########
@@ -611,6 +603,7 @@ public Object doCall() throws IOException
}
theSinks.put(identifier, sink);
sink.finishWriting();
+ totalRows.addAndGet(-sink.getNumRows());
Review comment:
Ok, I re-read it, less dumbly this time, and it looks good to me. But
consider the finishWriting-returning-boolean thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
