drcrallen commented on a change in pull request #6629: Add support parallel
combine in brokers
URL: https://github.com/apache/incubator-druid/pull/6629#discussion_r240735338
##########
File path: core/src/main/java/org/apache/druid/java/util/common/DateTimes.java
##########
@@ -99,6 +99,11 @@ public static DateTime of(String instant)
return new DateTime(instant, ISOChronology.getInstanceUTC());
}
+ public static DateTime of(String format, Object... formatArgs)
Review comment:
This seems a little unnatural to me IMHO. `DateTime.of` that actually does
string formatting is a bit surprising. I propose changing the method name to
something more descriptive to what the method is doing, or just use
`StringUtils.format` in the callers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
