drcrallen commented on a change in pull request #6629: Add support parallel
combine in brokers
URL: https://github.com/apache/incubator-druid/pull/6629#discussion_r244820686
##########
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/MergeSequence.java
##########
@@ -46,22 +46,20 @@ public MergeSequence(
@Override
public <OutType> Yielder<OutType> toYielder(OutType initValue,
YieldingAccumulator<OutType, T> accumulator)
{
- PriorityQueue<Yielder<T>> pQueue = new PriorityQueue<>(
- 32,
- ordering.onResultOf(
- new Function<Yielder<T>, T>()
- {
- @Override
- public T apply(Yielder<T> input)
- {
- return input.get();
- }
- }
- )
- );
-
- pQueue = baseSequences.accumulate(
- pQueue,
+ PriorityQueue<Yielder<T>> pQueue = baseSequences.accumulate(
+ new PriorityQueue<>(
+ 32,
Review comment:
If anyone finds this comment through code archeology, this constant was me
just poking around and trying stuff. It is not thoroughly tested :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
