drcrallen commented on a change in pull request #6629: Add support parallel
combine in brokers
URL: https://github.com/apache/incubator-druid/pull/6629#discussion_r244819541
##########
File path: core/src/main/java/org/apache/druid/collections/BlockingPool.java
##########
@@ -24,8 +24,21 @@
public interface BlockingPool<T>
{
+ /**
+ * Returns the total pool size.
+ */
int maxSize();
+ /**
+ * Returns the number of current available resources.
+ */
+ int available();
+
+ /**
+ * Poll all available resources from the pool. If there's no available
resource, it returns an empty list.
Review comment:
I'm trying to think as a new developer. What would reduce the total spinup
time to get effective contributions. There's a lot of methods which are kind of
like core java methods, but are a little different, and it gets hard to
differentiate what is important and what is not.
IMHO "This is a subset of `BlockingQueue` with some other added features,
but we don't want to depend on keeping up with `BlockingQueue` upstream
changes" is an easier story than "We made up our own interfaces that behave
different than other things you've seen, and you have to learn about how the
new interfaces are and are not enforced"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
