drcrallen commented on a change in pull request #6629: Add support parallel
combine in brokers
URL: https://github.com/apache/incubator-druid/pull/6629#discussion_r240734370
##########
File path:
core/src/main/java/org/apache/druid/collections/DefaultBlockingPool.java
##########
@@ -70,10 +70,34 @@ public int maxSize()
return maxSize;
}
- @VisibleForTesting
- public int getPoolSize()
+ @Override
+ public int available()
{
- return objects.size();
+ final ReentrantLock lock = this.lock;
+ lock.lock();
Review comment:
Why bother locking if the size returned is immediately going to be invalid?
aka, some other thread may have already changed the size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
