clintropolis commented on code in PR #17691:
URL: https://github.com/apache/druid/pull/17691#discussion_r1937956015
##########
extensions-contrib/compressed-bigdecimal/src/main/java/org/apache/druid/compressedbigdecimal/CompressedBigDecimalLongColumnSerializer.java:
##########
@@ -66,7 +67,8 @@ public static CompressedBigDecimalLongColumnSerializer create(
segmentWriteOutMedium,
String.format(Locale.ROOT, "%s.magnitude", filenameBase),
Integer.MAX_VALUE,
- CompressionStrategy.LZ4
+ CompressionStrategy.LZ4,
+ GenericIndexedWriter.MAX_FILE_SIZE
Review Comment:
is there any reason to call this in non-test code with any value other than
`GenericIndexedWriter.MAX_FILE_SIZE`? like wondering if we should make a
version of the creators that automatically passes this argument in and mark the
one that takes the size argument as for tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
