gianm commented on code in PR #17691:
URL: https://github.com/apache/druid/pull/17691#discussion_r1937970941
##########
extensions-contrib/compressed-bigdecimal/src/main/java/org/apache/druid/compressedbigdecimal/CompressedBigDecimalLongColumnSerializer.java:
##########
@@ -66,7 +67,8 @@ public static CompressedBigDecimalLongColumnSerializer create(
segmentWriteOutMedium,
String.format(Locale.ROOT, "%s.magnitude", filenameBase),
Integer.MAX_VALUE,
- CompressionStrategy.LZ4
+ CompressionStrategy.LZ4,
+ GenericIndexedWriter.MAX_FILE_SIZE
Review Comment:
I thought about this, but this seemed fine enough and makes the
`GenericIndexedWriter` API less cluttered. Having two overloads of the method
with slightly different arguments seemed like it might be confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
