gianm commented on code in PR #17691:
URL: https://github.com/apache/druid/pull/17691#discussion_r1938012649
##########
extensions-contrib/compressed-bigdecimal/src/main/java/org/apache/druid/compressedbigdecimal/CompressedBigDecimalLongColumnSerializer.java:
##########
@@ -66,7 +67,8 @@ public static CompressedBigDecimalLongColumnSerializer create(
segmentWriteOutMedium,
String.format(Locale.ROOT, "%s.magnitude", filenameBase),
Integer.MAX_VALUE,
- CompressionStrategy.LZ4
+ CompressionStrategy.LZ4,
+ GenericIndexedWriter.MAX_FILE_SIZE
Review Comment:
I added a javadoc to the `GenericIndexedWriter#ofCompressedByteBuffers` and
`V3CompressedVSizeColumnarMultiIntsSerializer#create` methods. There are some
other methods that now accept `fileSizeLimit`, but they are package-private so
are really only used by tests and by closely-related code. I didn't add
javadocs to those since it didn't seem necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
