clintropolis commented on code in PR #17691:
URL: https://github.com/apache/druid/pull/17691#discussion_r1937974847
##########
extensions-contrib/compressed-bigdecimal/src/main/java/org/apache/druid/compressedbigdecimal/CompressedBigDecimalLongColumnSerializer.java:
##########
@@ -66,7 +67,8 @@ public static CompressedBigDecimalLongColumnSerializer create(
segmentWriteOutMedium,
String.format(Locale.ROOT, "%s.magnitude", filenameBase),
Integer.MAX_VALUE,
- CompressionStrategy.LZ4
+ CompressionStrategy.LZ4,
+ GenericIndexedWriter.MAX_FILE_SIZE
Review Comment:
yea, i guess new callers of these methods aren’t very frequent so maybe its
ok. I was just afraid it just seems more confusing for the production code to
be accepting an argument where there is basically one reasonable value to ever
pass in, so any new callers should hopefully check around to see what the other
callers are doing to pass in the same constant. Maybe we should add javadocs on
these create methods to indicate that most callers should specify
`GenericIndexedWriter.MAX_FILE_SIZE` as the argument except for testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
