kgyrtkirk commented on code in PR #18070:
URL: https://github.com/apache/druid/pull/18070#discussion_r2125859483
##########
.github/workflows/ci.yml:
##########
@@ -55,11 +56,19 @@ jobs:
check_retries: true
truncate_stack_traces: false
+ check-labels:
+ name: "coverage-jacoco-do-not-submit"
+ # Skip coverage test if PR has 'jacoco:skip' label
+ if: ${{ github.event_name != 'pull_request' ||
!contains(github.event.pull_request.labels, 'jacoco:skip') }}
+ runs-on: ubuntu-latest
+ steps:
+ - run: echo "labels are ${{ toJson(github.event.pull_request.labels) }}"
+
reporting-jacoco-coverage-failures:
name: "coverage-jacoco"
- needs: run-unit-tests
+ # Skip coverage test if PR has 'jacoco:skip' label
Review Comment:
I don't think this really changes anything - you could read the labels thru
github api - but in any case I think it would be better to just stuck with new
commits and/or open&close to run this.
##########
.github/workflows/ci.yml:
##########
@@ -21,6 +21,7 @@ on:
jobs:
run-unit-tests:
name: "unit tests(main)"
+ if: ${{ github.event.action != 'labeled' && github.event.action !=
'unlabeled' }}
Review Comment:
this is very bad - and will make it a pain to look for the results:
* commit w/o label triggers -> CI starts but not finishes
* pr labeled -> a run w/o unit test runs will be presented
should never be any `ifs` like this
##########
.github/workflows/unit-and-integration-tests-unified.yml:
##########
@@ -41,6 +41,7 @@ on:
- master
- '[0-9]+.[0-9]+.[0-9]+' # release branches
- '[0-9]+.[0-9]+.[0-9]+-[A-Za-z0-9]+' # release branches
+ types: [ opened, reopened, synchronize, labeled, unlabeled ]
Review Comment:
please don't add triggers on `labeled` / `unlabeled` ; this will implicitly
cause further issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
