cecemei commented on code in PR #18070:
URL: https://github.com/apache/druid/pull/18070#discussion_r2127079823
##########
.github/workflows/ci.yml:
##########
@@ -21,6 +21,7 @@ on:
jobs:
run-unit-tests:
name: "unit tests(main)"
+ if: ${{ github.event.action != 'labeled' && github.event.action !=
'unlabeled' }}
Review Comment:
Thought more on this, pr open/close should not matter, and here's a
promising approach is to separate coverage to into another workflow, and it can
be triggered by:
-
[workflow_run](https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_run)
from unit test, so it can get the unit test reports and report coverage. This
also means unit test reports need to be cached for usage between workflow runs.
- label/ unlabel events. if skip label is present in the pr, the workflow
would just skip, otherwise, the workflow would run as one of the following:
- handle gracefully if restore cache fails because the unit test workflow
has not finish. This is fine because it'd be triggered again once the unit test
workflow triggers.
- unit test workflow has ran before, so just re-run the check coverage
script.
However, it looks like we don't use workflow_run triggers currently and it
might make the triggering a bit complicated, so I think I might just do a
smaller clean up in this one, and maybe work on that in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
