kgyrtkirk commented on code in PR #18070:
URL: https://github.com/apache/druid/pull/18070#discussion_r2126285967
##########
.github/workflows/unit-and-integration-tests-unified.yml:
##########
@@ -41,6 +41,7 @@ on:
- master
- '[0-9]+.[0-9]+.[0-9]+' # release branches
- '[0-9]+.[0-9]+.[0-9]+-[A-Za-z0-9]+' # release branches
+ types: [ opened, reopened, synchronize, labeled, unlabeled ]
Review Comment:
I have seen other projects using these events (calcite is one) - and was
thinking about it some time ago....
I think the best is to separate jobs which are triggered on label changes
and CI checks should be independent.
With the current setup: if someone adds an irrelevant label to PR it will
right away abort all CI jobs - and start new ones with the `labeled` event (for
which in the current setup it won't run unit tests).
A different approach could be to create a new job which is watching the
labels and if a relevant label is changed it somehow restarts the main CI job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
