kgyrtkirk commented on code in PR #18070:
URL: https://github.com/apache/druid/pull/18070#discussion_r2126270975
##########
.github/workflows/ci.yml:
##########
@@ -21,6 +21,7 @@ on:
jobs:
run-unit-tests:
name: "unit tests(main)"
+ if: ${{ github.event.action != 'labeled' && github.event.action !=
'unlabeled' }}
Review Comment:
@gianm : I've tried to sketch the scenario above; but it may have been vague.
I've added the `jacoco:skip` label to this PR 2 hours ago and now:
* the last commit has a green :heavy_check_mark:.
* meanwhile all the unit test jobs which were guarded by this `if` are
missing as they are *skipped*
* its impossible to tell if in the previous run the unit tests were passing
; failed ; didn't even run (it was still being scheduled when the new event
kicked out it from the queue)
this becomes more frustrating if someone is looking for reasons some things
have happened in the master branch - like 2 conflicting commits (both green
individually but break each other for some reason)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
