clintropolis commented on code in PR #18078:
URL: https://github.com/apache/druid/pull/18078#discussion_r2130397028
##########
processing/src/main/java/org/apache/druid/segment/virtual/ExpressionSelectors.java:
##########
@@ -132,35 +83,8 @@ public static ColumnValueSelector
makeStringColumnValueSelector(
{
final ColumnValueSelector<ExprEval> baseSelector =
makeExprEvalSelector(columnSelectorFactory, expression);
- return new ColumnValueSelector()
+ return new EvalUnwrappingColumnValueSelector(baseSelector)
Review Comment:
getObject is called per row, so i don't think we want to have a flag that
must be checked every row by all implementations. This coerceEvalToObjectOrList
is specific to multi-value strings, expression handling doesn't know about
multi-value strings and so processes them as ARRAY<STRING>, but then must
coerce them back into the List used by multi-value strings in the native layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
