clintropolis commented on code in PR #18078:
URL: https://github.com/apache/druid/pull/18078#discussion_r2131106856
##########
processing/src/main/java/org/apache/druid/segment/virtual/ExpressionSelectors.java:
##########
@@ -169,19 +93,28 @@ public Object getObject()
ExprEval eval = baseSelector.getObject();
return coerceEvalToObjectOrList(eval);
}
+ };
+ }
+ public static ColumnValueSelector castColumnValueSelector(
Review Comment:
ah, right now it has to be non-null and would explode in
`fromColumnTypeStrict`, however it doesn't really need to be...
`ExprEval.ofType` falls back to `ExprEval.bestEffortOf` if type is null, so we
could handle all casts with this. Will update PR and add some tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
