clintropolis commented on code in PR #18078:
URL: https://github.com/apache/druid/pull/18078#discussion_r2131069185
##########
processing/src/main/java/org/apache/druid/segment/nested/NestedFieldDictionaryEncodedColumn.java:
##########
@@ -163,11 +159,11 @@ public IndexedInts getMultiValueRow(int rowNum)
public String lookupName(int id)
{
final int globalId = dictionary.get(id);
- if (globalId < globalDictionary.size()) {
Review Comment:
ah just cleanup, i noticed while in debugger.. there are other similar
places in code that re-use these precomputed values since these dictionaries
don't ever change size and we already computed them for other reasons too, so
was just cleaning up to re-use here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
