clintropolis commented on code in PR #18078: URL: https://github.com/apache/druid/pull/18078#discussion_r2130412385
########## sql/src/test/java/org/apache/druid/sql/calcite/CalciteNestedDataQueryTest.java: ########## @@ -6804,44 +6804,93 @@ public void testUnnestJsonQueryArraysJsonValueSum() @Test public void testJsonValueNestedEmptyArray() Review Comment: ah the all empty arrays column was a test for the type system during array ingestion, since there are no elements we cannot infer an array type so we just handle this column as the most restrictive array type, which is ARRAY<LONG>. I think there should be some other objects/fields with arrays with values, or could be separately added to the input data file if there is some shape that isn't already covered rather than changing this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
