kfaraz commented on code in PR #18082:
URL: https://github.com/apache/druid/pull/18082#discussion_r2140716589
##########
extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java:
##########
@@ -3282,7 +3283,7 @@ public void testStop()
{
EasyMock.expect(taskMaster.getTaskRunner()).andReturn(Optional.of(taskRunner)).anyTimes();
taskClient.close();
- taskRunner.unregisterListener(StringUtils.format("KafkaSupervisor-%s",
DATASOURCE));
Review Comment:
Hmm. Why do you feel that is incorrect?
The task listener ID etc are just in-memory values which need not exactly
match any actual persisted ID or any other value in the system.
They are similar to thread names in the sense that the names should be
representative of the underlying entity
but need not match anything exactly.
The current scheme of naming `KafkaSupervisor-*` makes sifting through logs
and thread dumps very convenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
