kfaraz commented on PR #18745: URL: https://github.com/apache/druid/pull/18745#issuecomment-3631029698
@Fly-Style , I think @jtuglu1 makes a fair point. I too would prefer that `taskCountStart` remain immutable and we retain the capability to reset the task count upon resubmission. How about the following approach instead? I have slightly different suggestion than the one captured in the PR description: - [x] When submitting a supervisor with auto-scaler disabled, use the `taskCount` as is. - [ ] When submitting a (new or existing) supervisor with auto-scaler enabled, set `taskCount = taskCountStart == null ? taskCountMin : taskCountStart`. Persist the supervisor. - [x] For any auto-scaling event, update the `taskCount` the same way that we do today. - [ ] When the supervisor starts, it should start with the `taskCount` as the starting number of tasks rather than `taskCountStart`. This would ensure: - the issue with Overlord restarts is fixed - `taskCountStart` remains an immutable config - `taskCount` always reflects the current task count in the supervisor What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
