Fly-Style commented on code in PR #18745:
URL: https://github.com/apache/druid/pull/18745#discussion_r2602756224
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -556,44 +566,52 @@ public String getType()
private boolean changeTaskCount(int desiredActiveTaskCount)
throws InterruptedException, ExecutionException
{
+ if (autoScalerConfig == null) {
+ log.warn("autoScalerConfig is 'null' but dynamic allocation notice is
submitted, how can it be ?");
+ return false;
+ }
int currentActiveTaskCount;
Collection<TaskGroup> activeTaskGroups =
activelyReadingTaskGroups.values();
currentActiveTaskCount = activeTaskGroups.size();
if (desiredActiveTaskCount < 0 || desiredActiveTaskCount ==
currentActiveTaskCount) {
return false;
- } else {
- log.info(
- "Starting scale action, current active task count is [%d] and
desired task count is [%d] for supervisor[%s] for dataSource[%s].",
- currentActiveTaskCount,
- desiredActiveTaskCount,
- supervisorId,
- dataSource
- );
- final Stopwatch scaleActionStopwatch = Stopwatch.createStarted();
- gracefulShutdownInternal();
- changeTaskCountInIOConfig(desiredActiveTaskCount);
- clearAllocationInfo();
- emitter.emit(ServiceMetricEvent.builder()
- .setDimension(DruidMetrics.SUPERVISOR_ID,
supervisorId)
- .setDimension(DruidMetrics.DATASOURCE,
dataSource)
- .setDimension(DruidMetrics.STREAM,
getIoConfig().getStream())
- .setDimensionIfNotNull(
- DruidMetrics.TAGS,
-
spec.getContextValue(DruidMetrics.TAGS)
- )
- .setMetric(
- AUTOSCALER_SCALING_TIME_METRIC,
- scaleActionStopwatch.millisElapsed()
- ));
- log.info("Changed taskCount to [%s] for supervisor[%s] for
dataSource[%s].", desiredActiveTaskCount, supervisorId, dataSource);
- return true;
}
+ log.info(
+ "Starting scale action, current active task count is [%d] and desired
task count is [%d] for supervisor[%s] for dataSource[%s].",
+ currentActiveTaskCount,
+ desiredActiveTaskCount,
+ supervisorId,
+ dataSource
+ );
+ final Stopwatch scaleActionStopwatch = Stopwatch.createStarted();
+ gracefulShutdownInternal();
+ changeTaskCountInAutoScalerConfig(desiredActiveTaskCount);
+ clearAllocationInfo();
+ emitter.emit(ServiceMetricEvent.builder()
+ .setDimension(DruidMetrics.SUPERVISOR_ID,
supervisorId)
+ .setDimension(DruidMetrics.DATASOURCE,
dataSource)
+ .setDimension(DruidMetrics.STREAM,
getIoConfig().getStream())
+ .setDimensionIfNotNull(
+ DruidMetrics.TAGS,
+ spec.getContextValue(DruidMetrics.TAGS)
+ )
+ .setMetric(
+ AUTOSCALER_SCALING_TIME_METRIC,
+ scaleActionStopwatch.millisElapsed()
+ ));
+ log.info("Changed taskCount to [%s] for supervisor[%s] for
dataSource[%s].", desiredActiveTaskCount, supervisorId, dataSource);
+ return true;
Review Comment:
Yeap, it is obsolete in my taste.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
