gianm commented on PR #18745:
URL: https://github.com/apache/druid/pull/18745#issuecomment-3633901364
> I'm open to some way of offering both behaviors. I personally feel like
sticking to the current task count on resubmitting is more intuitive as a
default (since it seems odd that changing schema would lead to a reset of the
task count). But I can live with the current behavior as default, as long as
there's some way to get the stick-to-current behavior. Currently, there isn't.
A possibility:
- When a supervisor is started through `supervisor.start()`, initial task
count is always taken from `taskCount`. This keeps task count consistent
through Overlord restarts, etc.
- When a supervisor is posted through `SupervisorResource#specPost`,
`taskCount` is set to:
1. `taskCountStart` if that is nonnull
2. else, the user-provided `taskCount` if that is nonnull
3. else, the `taskCount` from the previous supervisor spec (in the DB) if
one exists
4. else, the user-provided `taskCountMin`
This I think allows @jtuglu1 and me to both have the behavior we want:
@jtuglu1 would set `taskCountStart` and the task count would always reset to
that. I would set neither `taskCount` nor `taskCountStart`, and the task count
would start out at `taskCountMin` for a fresh supervisor, then retain the
current count from then on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
