kfaraz commented on PR #18745: URL: https://github.com/apache/druid/pull/18745#issuecomment-3632293049
> Similarly, have you tested what happens when a supervisor is terminated (tombstoned) and then resubmitted without a taskCountStart? It'd be good to make sure that we don't end up merging an old supervisor (with same ID) data with potentially unrelated, new supervisor's data. @jtuglu1 , this is already handled since the `SupervisorManager` contains only the non-tombstoned latest supervisor versions in memory. But we could add an embedded test to verify the same. @Fly-Style , let's try to add an embedded test for `LagBasedAutoScaler` similar to what you are doing in the other PR for cost-based auto-scaler. The test could have a method which verifies that we do not pick up the `taskCountStart` from tombstoned versions, even if the supervisor id is the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
