Fly-Style commented on code in PR #18745:
URL: https://github.com/apache/druid/pull/18745#discussion_r2611305867
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorSpec.java:
##########
@@ -255,6 +261,33 @@ public void validateSpecUpdateTo(SupervisorSpec
proposedSpec) throws DruidExcept
}
}
+ @Override
+ public void merge(@NotNull SupervisorSpec existingSpec)
+ {
+ AutoScalerConfig thisAutoScalerConfig =
this.getIoConfig().getAutoScalerConfig();
+ // Either if autoscaler is absent or taskCountStart is specified - just
return.
+ if (thisAutoScalerConfig == null ||
thisAutoScalerConfig.getTaskCountStart() != null) {
+ return;
+ }
Review Comment:
Not really, taskCountStart has bigger priority :)
> the priority: provided `taskCountStart` > provided `taskCount` > existing
`taskCount` > provided `taskCountMin`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
