abhishekrb19 commented on code in PR #18876:
URL: https://github.com/apache/druid/pull/18876#discussion_r2653274981
##########
processing/src/test/java/org/apache/druid/java/util/metrics/StubServiceEmitter.java:
##########
@@ -173,5 +191,11 @@ public void flush()
@Override
public void close()
{
+ try {
+ emitter.close();
Review Comment:
Ah, I intended to delegate this to the base class via `super.close()` here,
similar to how `start()` invokes `super.start()` to delegate to the base class,
which takes care of additional initialization. We could skip this in `close()`
as it doesn't do much, but it feels cleaner to do the same way here as well for
completeness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
