abhishekrb19 commented on code in PR #18876:
URL: https://github.com/apache/druid/pull/18876#discussion_r2653305121
##########
processing/src/main/java/org/apache/druid/java/util/metrics/Monitors.java:
##########
@@ -20,43 +20,39 @@
package org.apache.druid.java.util.metrics;
import java.util.List;
-import java.util.Map;
public class Monitors
{
/**
* Creates a JVM monitor, configured with the given dimensions, that gathers
all currently available JVM-wide
* monitors. Emitted events have default feed {@link
FeedDefiningMonitor#DEFAULT_METRICS_FEED}
- * See: {@link Monitors#createCompoundJvmMonitor(Map, String)}
- *
- * @param dimensions common dimensions to configure the JVM monitor with
+ * See: {@link Monitors#createCompoundJvmMonitor(String)}
*
* @return a universally useful JVM-wide monitor
*/
- public static Monitor createCompoundJvmMonitor(Map<String, String[]>
dimensions)
+ public static Monitor createCompoundJvmMonitor()
Review Comment:
I don’t think so. Opened a separate PR to remove this unused class
altogether: https://github.com/apache/druid/pull/18877/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
