abhishekrb19 commented on PR #18876: URL: https://github.com/apache/druid/pull/18876#issuecomment-3699816249
@kfaraz thanks for taking a look! > @abhishekrb19 , did you mean monitors like CgroupCpuMonitor which do have a Map<String, String[]> dimensions as a constructor arg but were still not wired up correctly? I couldn't figure out how these dimensions were getting injected in the original code. That's right, all the `Cgroup*` monitors were previously initialized with an empty dimensions map via the default constructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
