abhishekrb19 commented on code in PR #18876: URL: https://github.com/apache/druid/pull/18876#discussion_r2653288778
########## processing/src/test/java/org/apache/druid/java/util/metrics/StubServiceEmitterModule.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.java.util.metrics; + +import com.google.inject.Binder; +import com.google.inject.Module; +import com.google.inject.Provides; +import com.google.inject.name.Named; +import org.apache.druid.guice.ManageLifecycle; +import org.apache.druid.java.util.emitter.core.Emitter; + +public class StubServiceEmitterModule implements Module Review Comment: Yeah, I considered doing this. However, all the unit tests use `StubServiceEmitter` directly and moving `LatchableEmitterModule` to processing would also require moving non-test classes like `DruidNode` and other dependencies from the server module into processing. Given that, I’ve left this test stub module in place for now and we can refactor these test dependencies later if needed. I’ve also wired TaskHolder into LatchableEmitterModule so the embedded tests can make use of it as needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
