kfaraz commented on code in PR #18968:
URL: https://github.com/apache/druid/pull/18968#discussion_r2795235216
##########
server/src/main/java/org/apache/druid/server/compaction/DataSourceCompactibleSegmentIterator.java:
##########
@@ -121,9 +125,11 @@ private void populateQueue(SegmentTimeline timeline,
List<Interval> skipInterval
if (!partialEternitySegments.isEmpty()) {
// Do not use the target segment granularity in the
CompactionCandidate
// as Granularities.getIterable() will cause OOM due to the above
issue
- CompactionCandidate candidatesWithStatus = CompactionCandidate
- .from(partialEternitySegments, null)
- .withCurrentStatus(CompactionStatus.skipped("Segments have
partial-eternity intervals"));
+ CompactionCandidate candidatesWithStatus =
Review Comment:
This class probably doesn't need to change in this PR.
The `Eligibility` should be computed and used only by the
`CompactionJobQueue` (and maybe `CompactSegments` for backward compatibility).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
