kfaraz commented on code in PR #18968:
URL: https://github.com/apache/druid/pull/18968#discussion_r2795265220
##########
server/src/main/java/org/apache/druid/server/compaction/CompactionStatus.java:
##########
@@ -346,8 +361,10 @@ static DimensionRangePartitionsSpec
getEffectiveRangePartitionsSpec(DimensionRan
*/
private static class Evaluator
Review Comment:
Yeah, I don't like the null returns much myself.
We should update each CHECK to return a `CheckResult` object instead of a
`CompactionStatus`.
The rest of this class should probably remain unchanged as it seems to be
bloating up the PR without much value added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
