kfaraz commented on code in PR #18968:
URL: https://github.com/apache/druid/pull/18968#discussion_r2772501203
##########
server/src/main/java/org/apache/druid/server/compaction/MostFragmentedIntervalFirstPolicy.java:
##########
@@ -47,13 +47,16 @@ public class MostFragmentedIntervalFirstPolicy extends
BaseCandidateSearchPolicy
private final int minUncompactedCount;
private final HumanReadableBytes minUncompactedBytes;
private final HumanReadableBytes maxAverageUncompactedBytesPerSegment;
+ private final double incrementalCompactionUncompactedBytesRatioThreshold;
@JsonCreator
public MostFragmentedIntervalFirstPolicy(
@JsonProperty("minUncompactedCount") @Nullable Integer
minUncompactedCount,
@JsonProperty("minUncompactedBytes") @Nullable HumanReadableBytes
minUncompactedBytes,
@JsonProperty("maxAverageUncompactedBytesPerSegment") @Nullable
HumanReadableBytes maxAverageUncompactedBytesPerSegment,
+ @JsonProperty("incrementalCompactionUncompactedBytesRatioThreshold")
@Nullable
Review Comment:
Yes, it is best to add this config in the same PR that adds the incremental
compaction feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
